Add the cluster-autoscaler addon #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
xmudrii
commented
Sep 15, 2020
|
@xmudrii it would be good also to document the usage of the addon. |
The cluster-autoscaler manifest has been fetched from https://github.com/kubernetes/autoscaler/blob/d97e3dc221e0143d7b0541f1012be994560b35f2/cluster-autoscaler/cloudprovider/clusterapi/examples/deployment.yaml The manifest doesn't work out of the box. Required changes are made in follow-up commits.
No additional changes to resources were made in this commit
The ClusterRole used in the original Cluster-API provider example manifest is lacking some roles causing cluster-autoscaler to show a bunch of warnings. This ClusterRole has been copied from the AWS provider example manifest. https://github.com/kubernetes/autoscaler/blob/63259fb5dd89baeb2a46b5b3b27ba6578066166e/cluster-autoscaler/cloudprovider/aws/examples/cluster-autoscaler-autodiscover.yaml#L10-L83 It's also used by some other providers as well. The original ClusterRole was also using rbac.authorization.k8s.io/v1beta1 instead of rbac.authorization.k8s.io/v1.
xmudrii
force-pushed
the
cluster-autoscaler-addon
branch
from
fb98596
to
9a727fc
Compare
xmudrii
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
LGTM label has been added. Git tree hash: 6474ac28a2672042a8ed84ee700ca0740e1d60d1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@toschneck This is only the initial PR to add the manifest. There are some changes required on the API/UI side, so we'll document it once everything is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the cluster-autoscaler addon.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #3642
Documentation:
TBD once implemented in the UI.
Does this PR introduce a user-facing change?: