Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support override etcd launcher image #5880

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Support override etcd launcher image #5880

merged 2 commits into from
Sep 17, 2020

Conversation

irozzo-1A
Copy link
Contributor

What this PR does / why we need it:
This PR allows to configure the repository to be used for the etcd-launcher repository in the KubermaticConfiguration consistently with the other images handled by the user-controller-manager.
The main advantage is that PRs that build locally for testing and pushed to a private repository can be used easily.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Make etcd-launcher repository configurable in KubermaticConfiguration.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. team/lifecycle size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2020
@moelsayed
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61216f95e0a39401eecfd4a5a7017be85c2b02e6

xrstf
xrstf approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moelsayed
Copy link
Contributor

/retest

1 similar comment
@irozzo-1A
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 2f34c05 into kubermatic:master Sep 17, 2020
@kubermatic-bot kubermatic-bot added this to the v2.15 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@moelsayed moelsayed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v2.15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@irozzo-1A @moelsayed @kubermatic-bot @xrstf