Fix comment on cluster field of vSphere datacenter spec #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
LGTM label has been added. Git tree hash: 386ca03940b75d6ccbfe58ee66b5db0527b98b70
|
irozzo-1A
force-pushed
the
update-vsphere-datacenter-docs
branch
from
3c7eaa0
to
6d4fa92
Compare
kubermatic-bot
added
team/ui
and removed
lgtm
|
/retest |
irozzo-1A
force-pushed
the
update-vsphere-datacenter-docs
branch
from
6d4fa92
to
b6ffc1f
Compare
kubermatic-bot
added
size/M
|
/retest |
|
LGTM label has been added. Git tree hash: 61385a4660e885c54a13ed4835510ca5e18f58c6
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irozzo-1A, lsviben, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the comment on the
Clusterfield inDatacenterSpecVSpherethat wrongly states it refers to the Kubernates cluster. In addition it specifies that this field is optional, and what is more important completely ignored.See: kubermatic/machine-controller#726 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: