Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint templates delete endpoint #5966

Merged

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Sep 29, 2020

What this PR does / why we need it:
Adds a delete endpoint for CT

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5894

Does this PR introduce a user-facing change?:

constraint templates delete endpoint for V2:
DELETE /api/v2/constrainttemplates/{ct_name}

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. team/ui size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 29, 2020
@lsviben
Copy link
Contributor Author

lsviben commented Sep 29, 2020

/retest

@lsviben lsviben requested a review from zreigz September 29, 2020 14:28
Copy link
Contributor

@zreigz zreigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 84488eb2e044327ba3ad28f74bdcbea7d46d56e2

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit dc7e23b into kubermatic:master Sep 30, 2020
@kubermatic-bot kubermatic-bot added this to the v2.16 milestone Sep 30, 2020
@scheeles scheeles modified the milestones: v2.16_1, v2.16 Oct 6, 2020
@lsviben lsviben deleted the constraint-templates-delete-endpoint branch September 23, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint template - delete endpoint
4 participants