Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint get list #6034

Merged
merged 11 commits into from
Oct 21, 2020
Merged

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Oct 15, 2020

What this PR does / why we need it:
Adds endpoints for LIST and GET for constraints. Also adds the constraint CRD and API objects.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5899

Does this PR introduce a user-facing change?:

constraint get and list endpoints for V2:
GET /api/v2/projects/{project_id}/kubernetes/clusters/{cluster_id}/constraints/{constraint_name}
GET /api/v2/projects/{project_id}/kubernetes/clusters/{cluster_id}/constraints

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. team/lifecycle size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 15, 2020
@lsviben lsviben requested a review from zreigz October 15, 2020 14:28
@zreigz
Copy link
Contributor

zreigz commented Oct 16, 2020

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6286a9e862e3eb80272eb7d05e107ca079e744a4

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2020
@lsviben
Copy link
Contributor Author

lsviben commented Oct 16, 2020

/retest

1 similar comment
@lsviben
Copy link
Contributor Author

lsviben commented Oct 16, 2020

/retest

pkg/crd/kubermatic/v1/constraint.go Show resolved Hide resolved
pkg/crd/kubermatic/v1/constraint.go Show resolved Hide resolved
pkg/crd/kubermatic/v1/constraint.go Show resolved Hide resolved
pkg/crd/kubermatic/v1/constraint.go Show resolved Hide resolved
pkg/crd/kubermatic/v1/constraint.go Show resolved Hide resolved
pkg/provider/kubernetes/constraint.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/constraint_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/constraint_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/constraint_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/constraint_test.go Outdated Show resolved Hide resolved
@moadqassem
Copy link
Member

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3a303873dc95959ed12fc3098f2ef7e16c261d25

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, moadqassem, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@kubermatic-bot kubermatic-bot merged commit 6d53d98 into kubermatic:master Oct 21, 2020
@lsviben lsviben deleted the constraint-get-list branch September 23, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPA Constraint - get list endpoints
4 participants