Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle warnings/errors in Helm CLI client #6076

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 23, 2020

What this PR does / why we need it:
With v3.3.2, Helm started to check the file mode for the given kubeconfig (helm/helm#8748). If the kuebconfig is world-readable, it issues a warning on stderr. Before this PR, our Helm CLI Client just combined stdout and stderr for simplicity, but this won't work anymore.

This PR splits stdout and stderr again, fixing the version check.

Which issue(s) this PR fixes:
Fixes #6070

Does this PR introduce a user-facing change?:

Improve Helm error handling in KKP Installer

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 23, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2020
@xrstf
Copy link
Contributor Author

xrstf commented Oct 23, 2020

/cherrypick release/v2.15

@kubermatic-bot
Copy link
Contributor

@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.15 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@moelsayed
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a816ffb7b219e09e2894d09401194d9744b68c5d

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #6083

In response to this:

/cherrypick release/v2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf deleted the helm-3-3-4 branch October 27, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubermatic-installer: unable to parse helm version output if extra messages are present
3 participants