-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to adjust the Docker image tag for addons #6102
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yes, it solves the addon image problem. 👍 |
LGTM label has been added. Git tree hash: 7995c11160ec441cd3856b9f653272115e223dcb
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release/v2.15 |
@xrstf: new pull request created: #6106 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This is a proposal to help with the current problem surrounding addons in KKP.
It is currently very har to impossible to develop custom addons, as new Docker images cannot be easily refered to in userclusters. This is because the KKP Operator did not allow changing any Docker tags, because it wants to keep its own internal migration logic simple (so it does not allow to override the KKP version). However, this had a significant fallout for the addons, where there are legitimate usecases for overriding the Docker image.
This proposal tries to combine the best of both worlds. We still want to make sure admins don't accidentally upgrade KKP and continue to use their old addons image (which would be possible if we allowed to completely override the image tag), but we also want to allow to "bump" the tag to make development easier.
To achieve this, this PR simply introduces the concept of a "version suffix" that is, if set, appended to the KKP version.
Fixes #6081 in my opinion.
Does this PR introduce a user-facing change?: