Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to adjust the Docker image tag for addons #6102

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 28, 2020

What this PR does / why we need it:
This is a proposal to help with the current problem surrounding addons in KKP.

It is currently very har to impossible to develop custom addons, as new Docker images cannot be easily refered to in userclusters. This is because the KKP Operator did not allow changing any Docker tags, because it wants to keep its own internal migration logic simple (so it does not allow to override the KKP version). However, this had a significant fallout for the addons, where there are legitimate usecases for overriding the Docker image.

This proposal tries to combine the best of both worlds. We still want to make sure admins don't accidentally upgrade KKP and continue to use their old addons image (which would be possible if we allowed to completely override the image tag), but we also want to allow to "bump" the tag to make development easier.

To achieve this, this PR simply introduces the concept of a "version suffix" that is, if set, appended to the KKP version.

Fixes #6081 in my opinion.

Does this PR introduce a user-facing change?:

Allow to customize the Docker image tag for Cluster Addons

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. team/lifecycle labels Oct 28, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2020
@zreigz
Copy link
Contributor

zreigz commented Oct 29, 2020

yes, it solves the addon image problem. 👍
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7995c11160ec441cd3856b9f653272115e223dcb

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit e990090 into kubermatic:master Oct 29, 2020
@xrstf
Copy link
Contributor Author

xrstf commented Oct 29, 2020

/cherrypick release/v2.15

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #6106

In response to this:

/cherrypick release/v2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed Controller Manager - imagePullPolicy for Addons needs to be "Always"
4 participants