Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create v2 endpoint to list machine deployments #6107

Merged
merged 2 commits into from
Oct 30, 2020
Merged

create v2 endpoint to list machine deployments #6107

merged 2 commits into from
Oct 30, 2020

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented Oct 30, 2020

What this PR does / why we need it: create v2 endpoint to list machine deployments

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

v2 endpoint to list machine deployments: GET /api/v2/projects/{project_id}/clusters/{cluster_id}/machinedeployments

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. team/ui size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2020
@zreigz zreigz requested a review from lsviben October 30, 2020 10:04
lsviben
lsviben reviewed Oct 30, 2020
View reviewed changes
pkg/handler/v2/machine/machine_test.go Outdated
return test.GenTestMachineDeployment(name, rawProviderSpec, selector, dynamicConfig)
}

func boolPtr(i bool) *bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding our own function you can use the pointer.BoolPtr from "k8s.io/utils/pointer" as its already used in a lot of places.

@lsviben
Copy link
Contributor

lsviben commented Oct 30, 2020

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d069ab86376a3973b6c1b9bfe21c23d76f87e5d2

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 0b0a606 into kubermatic:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsviben lsviben lsviben left review comments

Assignees

@lsviben lsviben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zreigz @lsviben @kubermatic-bot