Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new v2 endpoint to list machine deployment nodes #6111

Merged

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented Nov 2, 2020

What this PR does / why we need it: new v2 endpoint to list machine deployment nodes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

new v2 endpoint to list machine deployment nodes: GET /api/v2/projects/{project_id}/clusters/{cluster_id}/machinedeployments/{machinedeployment_id}/nodes

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. team/ui size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 2, 2020
@zreigz zreigz force-pushed the v2-list_machine_deployment_nodes branch from 46d93cd to 618d035 Compare November 2, 2020 14:34
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 2, 2020
@zreigz zreigz force-pushed the v2-list_machine_deployment_nodes branch 2 times, most recently from 455939f to 46005f7 Compare November 3, 2020 08:18
@zreigz zreigz requested a review from lsviben November 3, 2020 08:50
@lsviben
Copy link
Contributor

lsviben commented Nov 3, 2020

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e3b04f715e69a4a18d4729cf84ed24ead261ec53

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2020
@zreigz zreigz force-pushed the v2-list_machine_deployment_nodes branch from 46005f7 to db34e86 Compare November 3, 2020 12:49
@kubermatic-bot kubermatic-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 3, 2020
@zreigz
Copy link
Contributor Author

zreigz commented Nov 3, 2020

I had to rebase
@lsviben PTAL

@lsviben
Copy link
Contributor

lsviben commented Nov 3, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d8c5c2d55519f2c51787c05efe87637d7fa1171b

@kubermatic-bot kubermatic-bot merged commit 20b9cb8 into kubermatic:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants