Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint delete endpoint #6116

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Constraint delete endpoint #6116

merged 3 commits into from
Nov 4, 2020

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Nov 3, 2020

What this PR does / why we need it:
Adds delete endpoint for constraints

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5902

Does this PR introduce a user-facing change?:

new endpoint for constraint delete: DELETE /api/v2/projects/{project_id}/clusters/{cluster_id}/constraints/{constraint_name}

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 3, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. team/ui labels Nov 3, 2020
@lsviben
Copy link
Contributor Author

lsviben commented Nov 3, 2020

/retest

2 similar comments
@lsviben
Copy link
Contributor Author

lsviben commented Nov 3, 2020

/retest

@lsviben
Copy link
Contributor Author

lsviben commented Nov 3, 2020

/retest

@lsviben lsviben requested a review from zreigz November 3, 2020 13:29
@lsviben
Copy link
Contributor Author

lsviben commented Nov 3, 2020

/retest

@zreigz
Copy link
Contributor

zreigz commented Nov 4, 2020

/retest

@zreigz
Copy link
Contributor

zreigz commented Nov 4, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 30541058c30a8c03b5b069340a0488771e3b4f64

@kubermatic-bot kubermatic-bot merged commit 17994b9 into kubermatic:master Nov 4, 2020
@lsviben lsviben deleted the constraint-delete-endpoint branch September 23, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zreigz zreigz Awaiting requested review from zreigz

Assignees

@zreigz zreigz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OPA Constraint - delete endpoint
3 participants
@lsviben @kubermatic-bot @zreigz