v2 endpoint to patch machine deployment #6136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
lsviben
reviewed
Nov 10, 2020
pkg/handler/common/machine.go
Outdated
| return nil, fmt.Errorf("cannot decode patched cluster: %v", err) | ||
| } | ||
|
|
||
| //TODO: We need to make the kubelet version configurable but restrict it to versions supported by the control plane |
There was a problem hiding this comment.
is this TODO still relevant? From what I see we are checking if the version is compatible below
|
/lgtm |
|
LGTM label has been added. Git tree hash: 910271a5e3ff431d79f63ac409a0a980ecf3ef80
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsviben, zreigz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@lsviben I had to rebase, PTAL |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 2b8b74ef412709028d56bae977089073a308f21c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: v2 endpoint to patch machine deployment
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #