Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cluster_info type label #6138

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix cluster_info type label #6138

merged 1 commit into from
Nov 9, 2020

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Nov 9, 2020

What this PR does / why we need it:
All clusters were seemingly Openshift clusters.

Which issue(s) this PR fixes:
Fixes #6120

Does this PR introduce a user-facing change?:

Fix Prometheus cluster_info metric having the wrong `type` label

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 9, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2020
@xrstf
Copy link
Contributor Author

xrstf commented Nov 9, 2020

/cherrypick release/v2.15

@kubermatic-bot
Copy link
Contributor

@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.15 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor Author

xrstf commented Nov 9, 2020

/retest

@moadqassem
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9116adb246bdb87178acaa5b3b8ce259c0a41815

@kubermatic-bot kubermatic-bot merged commit 58afac2 into kubermatic:master Nov 9, 2020
@kubermatic-bot kubermatic-bot mentioned this pull request Nov 9, 2020
Merged
@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #6140

In response to this:

/cherrypick release/v2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf deleted the fix-cluster-metrics branch November 9, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moadqassem moadqassem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grafana Dashboard - wrong type of cluster
3 participants
@xrstf @kubermatic-bot @moadqassem