Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNSDomain to addon TemplateData #6160

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Add DNSDomain to addon TemplateData #6160

merged 2 commits into from
Nov 18, 2020

Conversation

phiphi282
Copy link
Contributor

What this PR does / why we need it:
We have some addons that would need the clusterDomain. Hardcoding
cluster.local is suboptimal.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Add DNSDomain variable to addon TemplateData

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Nov 16, 2020
@phiphi282 phiphi282 changed the title Add DNSDomain to ClusterData Add DNSDomain to addon TemplateData Nov 16, 2020
@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2020
@kubermatic-bot
Copy link
Contributor

Hi @phiphi282. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2020
@phiphi282
Add DNSDomain to ClusterData
1d66b43 
We have some addons that would need the clusterDomain. Hardcoding
cluster.local is suboptimal.

Signed-off-by: Phillip Stagnet <p.stagnet@syseleven.de>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Nov 16, 2020
@phiphi282
Copy link
Contributor Author

/assign @maciaszczykm

@xrstf
Copy link
Contributor

xrstf commented Nov 17, 2020

/ok-to-test
/test all

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2020
@phiphi282
Set cluster domain in addons
2723389 
Before addons used hardcoded cluster domain

Signed-off-by: Phillip Stagnet <p.stagnet@syseleven.de>
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2020
xrstf
xrstf approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02bdd39912ac1192e857a4922beab65726ca3bb5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phiphi282, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@xrstf
Copy link
Contributor

xrstf commented Nov 18, 2020

/retest

@kubermatic-bot kubermatic-bot merged commit 52b7511 into kubermatic:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@maciaszczykm maciaszczykm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phiphi282 @kubermatic-bot @xrstf @maciaszczykm