Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 add role and cluster role binding #6177

Merged
merged 2 commits into from
Nov 23, 2020
Merged

v2 add role and cluster role binding #6177

merged 2 commits into from
Nov 23, 2020

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented Nov 19, 2020

What this PR does / why we need it: v2 add role and cluster role binding

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

v2 adds role and cluster role binding:
POST /api/v2/projects/{project_id}/clusters/{cluster_id}/clusterroles/{role_id}/clusterbindings
POST /api/v2/projects/{project_id}/clusters/{cluster_id}/roles/{namespace}/{role_id}/bindings

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. team/lifecycle size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 19, 2020
@zreigz
Copy link
Contributor Author

zreigz commented Nov 19, 2020

/retest

@zreigz zreigz requested a review from lsviben November 19, 2020 12:39
@zreigz
Copy link
Contributor Author

zreigz commented Nov 19, 2020

/retest

@zreigz
Copy link
Contributor Author

zreigz commented Nov 20, 2020

@lsviben PTAL

lsviben
lsviben reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@lsviben lsviben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4089e0c0b18812337ebc53043458a08c7e4dd9b3

@zreigz
Copy link
Contributor Author

zreigz commented Nov 23, 2020

@moadqassem PTAL

moadqassem
moadqassem reviewed Nov 23, 2020
View reviewed changes
pkg/handler/common/binding.go Outdated Show resolved Hide resolved
pkg/handler/common/binding.go Outdated Show resolved Hide resolved
pkg/handler/common/binding.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@zreigz
Copy link
Contributor Author

zreigz commented Nov 23, 2020

@moadqassem PTAL

@moadqassem
Copy link
Member

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa5d41f561cd2557f8b956e1b9eaca0bd1833e62

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, moadqassem, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@kubermatic-bot kubermatic-bot merged commit 6cf0916 into kubermatic:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem moadqassem left review comments

@lsviben lsviben lsviben left review comments

Assignees

@moadqassem moadqassem

@lsviben lsviben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zreigz @kubermatic-bot @moadqassem @lsviben