-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 endpoints to manage addons #6215
Conversation
9c90256
to
bee1f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor import comment
pkg/handler/test/helper.go
Outdated
@@ -30,6 +30,8 @@ import ( | |||
"testing" | |||
"time" | |||
|
|||
k8sjson "k8s.io/apimachinery/pkg/util/json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put it below with the k8s imports
bee1f0a
to
8f336f0
Compare
/lgtm |
LGTM label has been added. Git tree hash: 9dcd07dd60c72376f5efaca2e26cd4cd6fa8bb60
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsviben, zreigz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: v2 endpoints to manage addons
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #6198