Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RBAC role to allow kubeadm to get nodes #6241

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 2, 2020

What this PR does / why we need it:

As of Kubernetes 1.18+, kubeadm verifies that there is no node with the same name before joining a new node to a cluster.

This PR adds a new manifest to the RBAC addon to grant kubeadm permissions to get nodes. Without this PR, nodes can't join kubeadm clusters running Kubernetes 1.18+

This manifest has been copied from the Kubernetes documentation and tested manually.

Reference: https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/troubleshooting-kubeadm/#not-possible-to-join-a-v1-18-node-to-a-v1-17-cluster-due-to-missing-rbac

This PR should be cherry-picked to branches with Kubernetes 1.18+ support.

Does this PR introduce a user-facing change?:

Create an RBAC role to allow kubeadm to get nodes. This fixes nodes failing to join kubeadm clusters running Kubernetes 1.18+

/assign @aborilov

@xmudrii xmudrii requested a review from aborilov December 2, 2020 12:59
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2020
@aborilov
Copy link
Contributor

aborilov commented Dec 2, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb66672022d3074527a11fceadf09b1076024343

@aborilov
Copy link
Contributor

aborilov commented Dec 2, 2020

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aborilov, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Dec 2, 2020

/test pre-kubermatic-e2e-aws-flatcar-1.17

@kubermatic-bot kubermatic-bot merged commit 3111712 into kubermatic:master Dec 2, 2020
@xmudrii xmudrii deleted the kubeadm-nodes-rbac branch December 2, 2020 15:34
@xmudrii
Copy link
Member Author

xmudrii commented Dec 2, 2020

/cherrypick release/v2.15
/cherrypick release/v2.14

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #6244

In response to this:

/cherrypick release/v2.15
/cherrypick release/v2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Dec 2, 2020

/cherrypick release/v2.14

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #6245

In response to this:

/cherrypick release/v2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants