Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to networking.k8s.io/v1beta1 for Ingresses #6292

Merged
merged 1 commit into from
Dec 10, 2020
Merged

migrate to networking.k8s.io/v1beta1 for Ingresses #6292

merged 1 commit into from
Dec 10, 2020

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Dec 10, 2020 •
edited
Loading

What this PR does / why we need it:
extensions/v1beta1 has been deprecated for Ingresses for quite some time.

Does this PR introduce a user-facing change?:

Update to networking.k8s.io/v1beta1 for managing Ingresses.

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 10, 2020
@xrstf xrstf force-pushed the extensions-v1beta1-deprecation branch from c2f4304 to b93be8d Compare December 10, 2020 15:07
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2020
@jiachengxu
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f48b50aa1b58e46f88d5b73643562039a388700b

@jiachengxu
Copy link
Contributor

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiachengxu, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@xrstf xrstf force-pushed the extensions-v1beta1-deprecation branch from b93be8d to c4911c8 Compare December 10, 2020 22:00
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@jiachengxu
Copy link
Contributor

/test pre-kubermatic-api-e2e
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e30d7791184cc946dfe62954c2b362036d92f7b9

@kubermatic-bot kubermatic-bot merged commit 7d3f339 into kubermatic:master Dec 10, 2020
@xrstf xrstf deleted the extensions-v1beta1-deprecation branch January 12, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jiachengxu jiachengxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @jiachengxu @kubermatic-bot