Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure endpoints to list resource and security groups #6340

Merged
merged 1 commit into from
Jan 8, 2021
Merged

azure endpoints to list resource and security groups #6340

merged 1 commit into from
Jan 8, 2021

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented Jan 5, 2021 •
edited
Loading

What this PR does / why we need it: azure endpoints to list resource and security groups

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6334

azure endpoints to list resource and security groups:
GET /api/v2/providers/azure/securitygroups
GET /api/v2/providers/azure/resourcegroups

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 5, 2021
@zreigz zreigz force-pushed the azure-resource-security-groups branch 2 times, most recently from 097d624 to a1a15d8 Compare January 5, 2021 13:03
@zreigz zreigz force-pushed the azure-resource-security-groups branch from a1a15d8 to 04413ac Compare January 5, 2021 13:14
@zreigz zreigz requested a review from lsviben January 6, 2021 17:57
@lsviben
Copy link
Contributor

lsviben commented Jan 8, 2021

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f27634c69ad07a0c51bcf05bd990eebcb196ac00

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 1e7c537 into kubermatic:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsviben lsviben Awaiting requested review from lsviben

Assignees

@lsviben lsviben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an endpoint to list Security Group for the Azure provider
3 participants
@zreigz @lsviben @kubermatic-bot