Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ServiceAccountSettings in cluster API object #6423

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Expose ServiceAccountSettings in cluster API object #6423

merged 1 commit into from
Jan 20, 2021

Conversation

jiachengxu
Copy link
Contributor

What this PR does / why we need it:
This PR exposes ServiceAccountSettings in cluster API object, so users can config service account token volume projection options via Kubermatic API.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6422

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Expose ServiceAccountSettings in cluster API object

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jan 18, 2021
@jiachengxu
Copy link
Contributor Author

/assign @lsviben

@lsviben
Copy link
Contributor

lsviben commented Jan 19, 2021

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6828057434db336a08a7675c6f0e12587c06de6f

@jiachengxu
Copy link
Contributor Author

/assign @moelsayed

@moelsayed
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiachengxu, lsviben, moelsayed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@jiachengxu
Copy link
Contributor Author

/test pre-kubermatic-verify

@kubermatic-bot kubermatic-bot merged commit ceb0b9f into kubermatic:master Jan 20, 2021
@jiachengxu jiachengxu deleted the sa-projection-api branch January 20, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moelsayed moelsayed

@lsviben lsviben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose ServiceAccountSettings in cluster API object
4 participants
@jiachengxu @lsviben @kubermatic-bot @moelsayed