documenting the user ssh key agent #6444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadqassem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
moadqassem
force-pushed
the
documenting-user-ssh-key-agent
branch
from
f525c1a
to
16d2c5c
Compare
xrstf
reviewed
Jan 25, 2021
cmd/user-ssh-keys-agent/README.md
Outdated
Comment on lines
12
to
13
| The agent is deployed to the user clusters by default and it is not possible to change whether to deploy it or not once the cluster | ||
| has been created. If users decide to disable the agent, they should take care of adding ssh keys to the worker nodes by themselves. |
There was a problem hiding this comment.
The most interesting question that will come up in half a year is "WHY can this not be changed after the creation?" -- can you describe the reasons or point the reader to where they can find out more?
xrstf
reviewed
Jan 25, 2021
cmd/user-ssh-keys-agent/README.md
Outdated
| has been created. If users decide to disable the agent, they should take care of adding ssh keys to the worker nodes by themselves. | ||
|
|
||
| **Note:** | ||
| During the user cluster creation steps(at the second step), the users have the possibility to add a user ssh key and it is not effected |
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
moadqassem
force-pushed
the
documenting-user-ssh-key-agent
branch
from
16d2c5c
to
3b2c496
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 0a8f96d25fa7fc9c59951c59a07521c9dbe36a1d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Documenting the user ssh key agent for having a better understanding about the functionality if the user ssh key
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #6430