Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed gatekeeper webhook admission version to v1beta1 #6550

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Feb 12, 2021

What this PR does / why we need it:
Fix issue with gatekeeper not recognizing the AdmissionReview v1 version by changing the webhook to use v1beta1

Does this PR introduce a user-facing change?:

Fix issue with gatekeeper not recognizing the AdmissionReview v1 version by changing the webhook to use v1beta1

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 12, 2021
@lsviben lsviben requested a review from xrstf February 12, 2021 11:34
@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2021
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0eb4509007772aa71b1757be4fff9a867fd2d4dc

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@kubermatic-bot kubermatic-bot merged commit 67786f2 into kubermatic:master Feb 12, 2021
@lsviben
Copy link
Contributor Author

lsviben commented Feb 12, 2021

/cherrypick release/v2.16

@kubermatic-bot
Copy link
Contributor

@lsviben: new pull request created: #6554

In response to this:

/cherrypick release/v2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lsviben lsviben deleted the use-v1beta1-admission-review-for-gatkeeper-webhook branch September 23, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants