Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSI driver #6594

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Update CSI driver #6594

merged 3 commits into from
Feb 26, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 23, 2021

What this PR does / why we need it:
To fix the bug with old CSI components

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6591

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Update CSI drivers

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2021
@kron4eg kron4eg requested a review from xrstf February 24, 2021 21:07
@xrstf
Copy link
Contributor

xrstf commented Feb 24, 2021

/test pre-kubermatic-e2e-openstack-centos-1.20

@xrstf
Copy link
Contributor

xrstf commented Feb 25, 2021

@kron4eg Shouldn't the openstack tests still pass?

@kron4eg
Copy link
Member Author

kron4eg commented Feb 25, 2021

/test pre-kubermatic-e2e-openstack-ubuntu-1.20

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Feb 25, 2021

/test pre-kubermatic-e2e-openstack-ubuntu-1.20

@kron4eg
Copy link
Member Author

kron4eg commented Feb 25, 2021

/test pre-kubermatic-e2e-openstack-ubuntu-1.20

@kron4eg
Copy link
Member Author

kron4eg commented Feb 25, 2021

@xrstf yeah, some RBAC permissions were missing

@kron4eg
Copy link
Member Author

kron4eg commented Feb 25, 2021

/retest

2 similar comments
@kron4eg
Copy link
Member Author

kron4eg commented Feb 25, 2021

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Feb 25, 2021

/retest

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 25, 2021 •
edited
Loading

@kron4eg: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pre-kubermatic-e2e-openstack-centos-1.20 2037931b497b9bb26bf0dd922116edf073f1205d link /test pre-kubermatic-e2e-openstack-centos-1.20

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Update CSI driver
c65e582 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Update RBAC rules acording to helm chart
8178703 
xref: https://github.com/kubernetes/cloud-provider-openstack/tree/master/charts/cinder-csi-plugin

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Increse e2e timeouts
92c3bae 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented Feb 26, 2021

/test pre-kubermatic-e2e-openstack-ubuntu-1.20

xrstf
xrstf approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a7ba1d1c02c1c436c679f91dc1b3d3495ed5d97

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2021
@kubermatic-bot kubermatic-bot merged commit ee44723 into master Feb 26, 2021
@kubermatic-bot kubermatic-bot deleted the 6591-csi-update branch February 26, 2021 17:46
@kron4eg
Copy link
Member Author

kron4eg commented Feb 26, 2021

/cherrypick release/v2.16

@kubermatic-bot
Copy link
Contributor

@kron4eg: #6594 failed to apply on top of branch "release/v2.16":

Applying: Update CSI driver
Using index info to reconstruct a base tree...
M	addons/csi/nodeplugin.yaml
Falling back to patching base and 3-way merge...
Auto-merging addons/csi/nodeplugin.yaml
CONFLICT (content): Merge conflict in addons/csi/nodeplugin.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update CSI driver
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kron4eg added a commit that referenced this pull request Feb 26, 2021
@kron4eg
Update CSI driver (#6594)
6fcc9ac 
* Update CSI driver

* Update RBAC rules acording to helm chart

xref: https://github.com/kubernetes/cloud-provider-openstack/tree/master/charts/cinder-csi-plugin

* Increse e2e timeouts

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg mentioned this pull request Feb 26, 2021
Merged
@xrstf xrstf mentioned this pull request Feb 26, 2021
Closed
kubermatic-bot pushed a commit that referenced this pull request Feb 26, 2021
@kron4eg
Update CSI driver (#6594) (#6607)
e27493c 
* Update CSI driver

* Update RBAC rules acording to helm chart

xref: https://github.com/kubernetes/cloud-provider-openstack/tree/master/charts/cinder-csi-plugin

* Increse e2e timeouts

Signed-off-by: Artiom Diomin <kron82@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CSI addon
3 participants
@kron4eg @xrstf @kubermatic-bot