Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CSI addon, update Hetzner CSI #6615

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Cleanup CSI addon, update Hetzner CSI #6615

merged 3 commits into from
Mar 2, 2021

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 1, 2021 •
edited
Loading

What this PR does / why we need it:
The new-ish csi addon was added with only Openstack support, yet we already had veeeery old hetzner CSI stuff in the default-storage-class addon. This PR cleans this up by moving the Hetzner CSI into the csi addon, keeping the StorageClass where it was.

To keep the addon organized, I also propose recursive directory scanning. All found YAML files are rendered into one gigantic manifest and then applied anyway.

Fixes #3312.

Does this PR introduce a user-facing change?:

Update Hetzner CSI, move to `csi` addon

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2021
@xrstf xrstf mentioned this pull request Mar 1, 2021
Closed
@xrstf
Copy link
Contributor Author

xrstf commented Mar 2, 2021

/test pre-kubermatic-e2e-hetzner-ubuntu-1.20

@xrstf
Copy link
Contributor Author

xrstf commented Mar 2, 2021

/hold

Needs #6588 first

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@xrstf xrstf changed the title WIP - Cleanup CSI addon, update Hetzner CSI Cleanup CSI addon, update Hetzner CSI Mar 2, 2021
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
@xrstf
Copy link
Contributor Author

xrstf commented Mar 2, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@xrstf
Copy link
Contributor Author

xrstf commented Mar 2, 2021

/retest

@rastislavs
Copy link
Contributor

/lgtm
/approve

I really like the recursive directory scanning idea!

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5113defc6d68c9a31ce3eddd211325a02a9974e8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rastislavs, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf
Copy link
Contributor Author

xrstf commented Mar 2, 2021

/test pre-kubermatic-e2e-hetzner-ubuntu-1.20

@xrstf
Copy link
Contributor Author

xrstf commented Mar 2, 2021

/retest

1 similar comment
@xrstf
Copy link
Contributor Author

xrstf commented Mar 2, 2021

/retest

@kubermatic-bot kubermatic-bot merged commit 28852c1 into kubermatic:master Mar 2, 2021
@xrstf xrstf deleted the cleanup-csi-addon branch March 2, 2021 10:41
@kubermatic-bot
Copy link
Contributor

@xrstf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pre-kubermatic-e2e-hetzner-ubuntu-1.20 2456996 link /test pre-kubermatic-e2e-hetzner-ubuntu-1.20

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

xrstf added a commit to xrstf/kubermatic that referenced this pull request Mar 2, 2021
@xrstf
[release/v2.16] Update Hetzner CSI (kubermatic#6615)
5a1e6ee
kubermatic-bot pushed a commit that referenced this pull request Mar 2, 2021
@xrstf
[release/v2.16] Update Hetzner CSI (#6615) (#6620)
a38de51 
* [release/v2.16] Update Hetzner CSI (#6615)

* enable storage tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rastislavs rastislavs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix & Update Hetzner CSI components
3 participants
@xrstf @rastislavs @kubermatic-bot