Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nginx-ingress-controller to 0.44.0 #6651

Merged
merged 2 commits into from
Mar 8, 2021
Merged

update nginx-ingress-controller to 0.44.0 #6651

merged 2 commits into from
Mar 8, 2021

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 8, 2021

What this PR does / why we need it:
What it says on the tin.

Fixes #6172

Does this PR introduce a user-facing change?:

update nginx-ingress-controller to 0.44.0

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. labels Mar 8, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2021
@jiachengxu
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17159d77e73d9621cc5a59b706c686563e89c331

@kubermatic-bot kubermatic-bot merged commit f81b43e into kubermatic:master Mar 8, 2021
@xrstf xrstf deleted the nginx-0.44 branch March 8, 2021 15:30
@toschneck
Copy link
Member

@xrstf @jiachengxu can we backport this to v2.16 branch as well. Recently came up this is need for a customer setup. not high-prio but with next realeas would be awesome

@xrstf
Copy link
Contributor Author

xrstf commented Mar 9, 2021

/cherrypick release/v2.16

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 9, 2021
Merged
@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #6675

In response to this:

/cherrypick release/v2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@toschneck
Copy link
Member

awesome thanks!

@xrstf xrstf added the kind/chore Updating grunt tasks etc; no production code changes. label Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jiachengxu jiachengxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation Option for nginx LoadBalancer Services
4 participants
@xrstf @kubermatic-bot @jiachengxu @toschneck