Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.16] Implement Project-Sync Controller #6754

Merged
merged 2 commits into from
Mar 24, 2021
Merged

[release/v2.16] Implement Project-Sync Controller #6754

merged 2 commits into from
Mar 24, 2021

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Mar 24, 2021

What this PR does / why we need it:

Cherry pick of #6708 to release/2.16. Needed to fix #6752

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6752

Does this PR introduce a user-facing change?:

Kubermatic Projects are now synced from the Master cluster to all Seed clusters. 
Fixed issue where user clusters could not be created properly on multi seed clusters, when the seed is not also the master cluster.

jiachengxu and others added 2 commits March 24, 2021 10:31
@jiachengxu @lsviben
Implement Project-Sync Controller (kubermatic#6708)
971996f 
* Add the first version of project controller

* Add unit test for project controller

* Uncomment code

* Uncomment code
@lsviben
adjust backport to older version of ctrlruntimeutil
45e9586
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 24, 2021
@lsviben lsviben mentioned this pull request Mar 24, 2021
Closed
@lsviben lsviben requested a review from xrstf March 24, 2021 10:27
@xrstf
Copy link
Contributor

xrstf commented Mar 24, 2021

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2bed7dbe4d7829f9645637fae017f5e3f483c089

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsviben, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@lsviben
Copy link
Contributor Author

lsviben commented Mar 24, 2021

/retest

1 similar comment
@lsviben
Copy link
Contributor Author

lsviben commented Mar 24, 2021

/retest

@kubermatic-bot kubermatic-bot merged commit 2c2bdb7 into kubermatic:release/v2.16 Mar 24, 2021
@lsviben lsviben deleted the cherry-pick-6708-to-release/v2.16 branch September 23, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsviben @xrstf @kubermatic-bot @jiachengxu