Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.16] Update machine-controller to 1.24.4 #6962

Merged
merged 2 commits into from
Apr 28, 2021
Merged

[release/v2.16] Update machine-controller to 1.24.4 #6962

merged 2 commits into from
Apr 28, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 28, 2021

Fixed the bug in machine-controller for us-east1 AWS zone with double instance creation

Fixes #6960

* Update machine-controller to 1.24.4
* Fixed double instance creation in us-east1 AWS

@kron4eg
Update machine-controller to 1.24.4
a226468 
Fixed the bug in machine-controller for us-east1 AWS zone with double
instance creation

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg requested a review from xmudrii April 28, 2021 11:34
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 28, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2021
@xmudrii
Copy link
Member

xmudrii commented Apr 28, 2021

/retest

@kron4eg kron4eg mentioned this pull request Apr 28, 2021
Closed
@kron4eg
MC 1.14.4 has dropped InsecureRegistries from UserDataRequest
5bdbde6 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg changed the title Update machine-controller to 1.24.4 [release/v2.16] Update machine-controller to 1.24.4 Apr 28, 2021
@xmudrii
Copy link
Member

xmudrii commented Apr 28, 2021

/retest

2 similar comments
@kron4eg
Copy link
Member Author

kron4eg commented Apr 28, 2021

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 28, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94de5d9364efef243ac5c8400e5e7d103c204a21

@kubermatic-bot kubermatic-bot merged commit ed88c5e into kubermatic:release/v2.16 Apr 28, 2021
@kron4eg kron4eg deleted the target-v2.16-update-mc-v1.24.4 branch April 28, 2021 15:02
@kron4eg kron4eg mentioned this pull request Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kron4eg @kubermatic-bot @xmudrii