Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable NodeLocal DNS Cache in user clusters #7075

Merged
merged 1 commit into from
May 20, 2021
Merged

Re-enable NodeLocal DNS Cache in user clusters #7075

merged 1 commit into from
May 20, 2021

Conversation

rastislavs
Copy link
Contributor

Signed-off-by: Rastislav Szabo rastislav@kubermatic.com

What this PR does / why we need it:
The NodeLocal DNS Cache is unconditionally deployed into user clusters, but currently it is not used due to #7058. This PR re-enables it.

The NodeLocal DNS Cache will be still deployed & enabled unconditionally, config / API option for enabling/disabling it will be introduced in #7074.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7058

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Re-enable NodeLocal DNS Cache in user clusters.

Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2021
@rastislavs
Copy link
Contributor Author

/retest

@youssefazrak
Copy link
Contributor

lgtm from my side

@irozzo-1A
Copy link
Contributor

/lgtm
/approve
same here ;-)

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 30870a4b8bb8b6cbbe26eb36c5bf3613a6de6861

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, rastislavs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [irozzo-1A,rastislavs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit c94f748 into kubermatic:master May 20, 2021
@rastislavs
Copy link
Contributor Author

/cherrypick release/v2.17
/cherrypick release/v2.16

@kubermatic-bot
Copy link
Contributor

@rastislavs: new pull request created: #7078

In response to this:

/cherrypick release/v2.17
/cherrypick release/v2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rastislavs
Copy link
Contributor Author

/cherrypick release/v2.16

@kubermatic-bot
Copy link
Contributor

@rastislavs: #7075 failed to apply on top of branch "release/v2.16":

Applying: Fix enabling NodeLocal DNS Cache
Using index info to reconstruct a base tree...
M	cmd/seed-controller-manager/controllers.go
M	cmd/seed-controller-manager/options.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/seed-controller-manager/options.go
CONFLICT (content): Merge conflict in cmd/seed-controller-manager/options.go
Auto-merging cmd/seed-controller-manager/controllers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix enabling NodeLocal DNS Cache
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-bot pushed a commit that referenced this pull request May 20, 2021
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@vgramer vgramer mentioned this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeLocal DNSCache is not used in user clusters
4 participants