-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClusterFeatureCCMClusterName feature for OpenStack clusters #7330
Add ClusterFeatureCCMClusterName feature for OpenStack clusters #7330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 4c236699306ba6af379ab7669bc250d334b7ad05
|
@xmudrii looks like we also need someone from sig-api |
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
cbcc72c
to
9f50962
Compare
/lgtm |
LGTM label has been added. Git tree hash: 90b84c93bbf9a4414457c6c54d1c5816e5308e40
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, maciaszczykm, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release/v2.17 |
/cherry-pick release/v2.16 |
@xmudrii: new pull request created: #7335 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xmudrii: new pull request created: #7336 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR introduces a cluster feature called
ccmClusterName
, which is used to apply the--cluster-name
flag on the external CCMs. Currently, this flag is only applied on the OpenStack CCM. In the future, it will be applied for the other cloud providers that support the external CCM as well.The
--cluster-name
flag is often used for naming cloud resources, such as Load Balancers. If it's not provided, the CCM would default it tokubernetes
.Not providing the
cluster-name
flag can cause conflicts as described in issue #7229.It's not possible to easily change this flag for the existing user clusters, as it can cause the external CCM to lose track of the existing cloud resources. Therefore, we're introducing a feature flag with the following behavior:
--cluster-name
flag on the external CCM deploymentWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #7332
Does this PR introduce a user-facing change?:
/assign @kron4eg