fix AWS cloud provider cleanup sometimes getting stuck when cleaning up tags

[xrstf]

What does this PR do / Why do we need it:
This fixes the rare case were all resources have been cleaned up already, but the finalizer was still stuck, leading to

{"level":"error","time":"2022-02-04T14:46:35.780Z","logger":"controller.kubermatic_cloud_controller","caller":"controller/controller.go:317","msg":"Reconciler error","name":"jmh6qqjgg7","namespace":"","error":"failed cloud provider cleanup: failed to clean up tags: InvalidParameterValue: Value ( ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid\n\tstatus code: 400, request id: 8edbfe54-2ca5-4dc9-9277-f0fcbde4597b","errorCauses":[{"error":"failed cloud provider cleanup: failed to clean up tags: InvalidParameterValue: Value ( ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid\n\tstatus code: 400, request id: 8edbfe54-2ca5-4dc9-9277-f0fcbde4597b"}]}

Does this PR introduce a user-facing change?:

fix AWS cloud provider cleanup sometimes getting stuck when cleaning up tags

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/provider/cloud/OWNERS [xrstf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xrstf]

/cherrypick release/v2.19
/cherrypick release/v2.20

[kubermatic-bot]

@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.19 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.19
/cherrypick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

LGTM label has been added.

Git tree hash: a35c8d94196be4368618d224d922a869eba0159a

[xrstf]

/retest

[kubermatic-triage-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[kubermatic-triage-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[kubermatic-bot]

@xrstf: new pull request created: #8885

In response to this:

/cherrypick release/v2.19
/cherrypick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

@xrstf: new pull request created: #8886

In response to this:

/cherrypick release/v2.19
/cherrypick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.