Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.20] Allow configuration for front-loadbalancer service of nodeportproxy #9486

Merged
merged 3 commits into from Mar 31, 2022
Merged

[release/v2.20] Allow configuration for front-loadbalancer service of nodeportproxy #9486

merged 3 commits into from Mar 31, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Mar 31, 2022 •
edited

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What does this PR do / Why do we need it:
Manual cherry-pick of #9476

Does this PR close any issues?:
Fixes #

Special notes for your reviewer:
Reason for manual cherry-pick #9476 (comment)

Documentation:

Does this PR introduce a user-facing change?:

- Add support for configuration annotations and loadBalancerSourceRanges for front-loadbalancer service of node port proxy
- For seed CR, spec.NodeportProxy.Annotations is deprecated and spec.NodeportProxy.Envoy.LoadBalancerService.Annotations should be used instead.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/crd size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2022
@ahmedwaleedmalik
Copy link
Member Author

/retest

xrstf
xrstf requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q

@ahmedwaleedmalik
Refactored code
b35ebb6 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
xrstf
xrstf approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b8e7e919ad2d5e3c358f9a4469ecb80fccbfefb

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@kubermatic-bot kubermatic-bot merged commit 3ffddaa into kubermatic:release/v2.20 Mar 31, 2022
@ahmedwaleedmalik ahmedwaleedmalik deleted the backport-configure-front-lb-service branch March 31, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/crd size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf