helm/cli: don't swallow error in BuildChartDependencies

[vgramer]

What does this PR do / Why do we need it:

In BuildChartDependencies function, we add the repositories, build the dependencies and thanks to a defer function, we remove the repository.

The problem is that if the helm repo add fails, the error is swallowed by the defer function. (doing helm repo remove with no repository added triggers the following error Error: no repositories configured. )

as you can see in this the root cause ( the error from the helm repo add ) is hidden.

INFO[10:05:22]    📦 Deploying nginx-ingress-controller…     
INFO[10:05:23]       Deploying Helm chart…                  
ERRO[10:05:23] ❌ Operation failed: failed to deploy nginx-ingress-controller: failed to deploy Helm release: failed to download dependencies: Error: no repositories configured. 

This PR moves the defer function after the helm add repo so we don't try to remove a repository that does not exist. It also combines previous errors (e.g. error from helm dependency build ) with error from helm repo remove repository.

Does this PR close any issues?:
Fixes #

Special notes for your reviewer:
Example of output for the different cases:

the case where add repo fails

INFO[17:38:35]    📦 Deploying nginx-ingress-controller…     
DEBU[17:38:35]       Ensuring namespace…                     namespace=nginx-ingress-controller
DEBU[17:38:35]       Checking for release…                   name=nginx-ingress-controller namespace=nginx-ingress-controller
DEBU[17:38:35] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace nginx-ingress-controller list --all -o json 
INFO[17:38:35]       Deploying Helm chart…                  
DEBU[17:38:35]       Installing…                            
DEBU[17:38:35] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default repo add dep-nginx-ingress-controller-0 https://kubernetes.github.io/ingress-nginx 
ERRO[17:38:35] ❌ Operation failed: failed to deploy nginx-ingress-controller: failed to deploy Helm release: failed to download dependencies: Error: open Library/Preferences/helm/repositories.yaml: permission denied. 
Exiting.

the case where build dependencies fails

INFO[17:40:27]    📦 Deploying nginx-ingress-controller…     
DEBU[17:40:27]       Ensuring namespace…                     namespace=nginx-ingress-controller
DEBU[17:40:27]       Checking for release…                   name=nginx-ingress-controller namespace=nginx-ingress-controller
DEBU[17:40:27] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace nginx-ingress-controller list --all -o json 
INFO[17:40:27]       Deploying Helm chart…                  
DEBU[17:40:27]       Installing…                            
DEBU[17:40:27] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default repo add dep-nginx-ingress-controller-0 https://kubernetes.github.io/ingress-nginx 
DEBU[17:40:35] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default dependency build charts/nginx-ingress-controller 
DEBU[17:40:38] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default repo remove dep-nginx-ingress-controller-0 
ERRO[17:40:38] ❌ Operation failed: failed to deploy nginx-ingress-controller: failed to deploy Helm release: failed to download dependencies: Error: could not download https://github.com/kubernetes/ingress-nginx/releases/download/helm-chart-4.1.0/ingress-nginx-4.1.0.tgz: Get "https://github.com/kubernetes/ingress-nginx/releases/download/helm-chart-4.1.0/ingress-nginx-4.1.0.tgz": dial tcp: lookup github.com on [::1]:53: read udp [::1]:57345->[::1]:53: read: connection refused. 
Exiting.

the case where build dependencies and remove repo fail

INFO[17:42:17]    📦 Deploying nginx-ingress-controller…     
DEBU[17:42:17]       Ensuring namespace…                     namespace=nginx-ingress-controller
DEBU[17:42:17]       Checking for release…                   name=nginx-ingress-controller namespace=nginx-ingress-controller
DEBU[17:42:17] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace nginx-ingress-controller list --all -o json 
INFO[17:42:17]       Deploying Helm chart…                  
DEBU[17:42:17]       Installing…                            
DEBU[17:42:17] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default repo add dep-nginx-ingress-controller-0 https://kubernetes.github.io/ingress-nginx 
DEBU[17:42:27] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default dependency build charts/nginx-ingress-controller 
DEBU[17:42:40] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default repo remove dep-nginx-ingress-controller-0 
ERRO[17:42:47] ❌ Operation failed: failed to deploy nginx-ingress-controller: failed to deploy Helm release: failed to download dependencies: Error: could not download https://github.com/kubernetes/ingress-nginx/releases/download/helm-chart-4.1.0/ingress-nginx-4.1.0.tgz: Get "https://github.com/kubernetes/ingress-nginx/releases/download/helm-chart-4.1.0/ingress-nginx-4.1.0.tgz": dial tcp: lookup github.com on [::1]:53: read udp [::1]:57919->[::1]:53: read: connection refused; error: clean up resources failed: can not remove remopository: Error: open Library/Preferences/helm/repositories.yaml: permission denied. 
Exiting.

the case where remove repo fails

INFO[17:43:36]    📦 Deploying nginx-ingress-controller…     
DEBU[17:43:36]       Ensuring namespace…                     namespace=nginx-ingress-controller
DEBU[17:43:36]       Checking for release…                   name=nginx-ingress-controller namespace=nginx-ingress-controller
DEBU[17:43:36] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace nginx-ingress-controller list --all -o json 
INFO[17:43:36]       Deploying Helm chart…                  
DEBU[17:43:36]       Installing…                            
DEBU[17:43:36] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default repo add dep-nginx-ingress-controller-0 https://kubernetes.github.io/ingress-nginx 
DEBU[17:43:49] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default dependency build charts/nginx-ingress-controller 
DEBU[17:43:51] $ KUBECONFIG=/Users/vince/.kube/config helm --namespace default repo remove dep-nginx-ingress-controller-0 
ERRO[17:43:51] ❌ Operation failed: failed to deploy nginx-ingress-controller: failed to deploy Helm release: failed to download dependencies: error: clean up resources failed: can not remove remopository: Error: open Library/Preferences/helm/repositories.yaml: permission denied. 
Exiting.

Documentation:

Does this PR introduce a user-facing change?:

kubermatic-installer: improve error handling when building helm chart dependencies

[xrstf]

I love this PR and its description!

/approve
/retest

[kubermatic-bot]

LGTM label has been added.

Git tree hash: e677ccda3ed3bd8d2db467b32d3de2adb1386fee

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vgramer, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/install/OWNERS [xrstf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vgramer]

/cherry-pick release/v2.20

[kubermatic-bot]

@vgramer: new pull request created: #9859

In response to this:

/cherry-pick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.