Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg integration #83

Closed
ahmedyarub opened this issue Sep 19, 2021 · 4 comments
Closed

vcpkg integration #83

ahmedyarub opened this issue Sep 19, 2021 · 4 comments

Comments

@ahmedyarub
Copy link
Contributor

I'm adding vcpkg integration for this library microsoft/vcpkg#20255
I tested it on Windows and it worked without any problem.
@ityuhui I remember that in a previous comment you said that the installation script would not work without adding the DESTINATION parameter. I had to patch that in vcpkg for the port to work. Can you please make sure that the installation really doesn't work without that parameter?
@ityuhui
Copy link
Member

ityuhui commented Sep 20, 2021

I tested it in Ubuntu 18.04 LTS, yes, DESTINATION is needed by this platform.

@ahmedyarub
Copy link
Contributor Author

Merged

@ityuhui
Copy link
Member

ityuhui commented Sep 23, 2021

@ahmedyarub
Could you please update the readme https://github.com/kubernetes-client/c/blob/master/README.md to tell user how to use it in vcpkg ?

@ahmedyarub
Copy link
Contributor Author

@ahmedyarub
Could you please update the readme https://github.com/kubernetes-client/c/blob/master/README.md to tell user how to use it in vcpkg ?

#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ityuhui @ahmedyarub