Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pprof for CSI sidecars #137

Closed
Fricounet opened this issue Jul 10, 2023 · 2 comments · Fixed by #138
Closed

Add support for pprof for CSI sidecars #137

Fricounet opened this issue Jul 10, 2023 · 2 comments · Fixed by #138

Comments

@Fricounet
Copy link
Contributor

Currently, some of the CSI sidecars support pprof profliing (like the azuredisk-csi-driver, the secrets-store-csi-driver or the node-driver-registrar but not all. I believe it could be useful to add this option on all CSI components and this repo seems like a good place to do it.

It could probably go in the metrics.go file in the CSIMetricsManager interface with a RegisterPprofToServer function that would register the pprof handlers.

What do you folks think about it? I would be happy to contribute this (and the implementation in the CSI sidecars) if that is something folks are willing to see 😄

@xing-yang
Copy link
Contributor

Hi @Fricounet , we discussed about this and agreed this is useful. Please go ahead and submit PRs. Thanks!

@jsafrane
Copy link
Contributor

I like it, but please make it configurable via --enable-pprof or something similar. Some CSI drivers need to use host network, i.e. the port for metrics + pprof will be open on the node. And at the same time, people may not like exposing CPU profiles, heap data and whatnot publicly on that node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants