Registrar command should fail upon unrecoverable error

[vladimirvivien]

Currently the registrar code is setup in a loop to continuously (https://github.com/kubernetes-csi/driver-registrar/blob/master/cmd/driver-registrar/k8s_register.go#L89) to attempt to reconcile the CSIDriver CRD object associated with the driver. However, when an unrecoverable error occur, the loop continues. This causes the container not to report the failure but instead continues to work.

For instance, the hostpath plugin pod shows that all containers are running

$> kubectl get pods
NAME                         READY   STATUS    RESTARTS   AGE
csi-hostpath-attacher-0      1/1     Running   0          15m
csi-hostpath-provisioner-0   1/1     Running   0          15m
csi-hostpathplugin-bshzn     3/3     Running   0          15m

However, the logs for the containers in the hostpath plugin shows unrecoverable errors:

E1004 20:40:29.135920       1 k8s_register.go:118] Failed to create CSIDriver object: csidrivers.csi.storage.k8s.io is forbidden: User "system:serviceaccount:default:csi-nodeplugin" cannot create resource "csidrivers" in API group "csi.storage.k8s.io" at the cluster scope
E1004 20:42:29.147958       1 k8s_register.go:118] Failed to create CSIDriver object: csidrivers.csi.storage.k8s.io is forbidden: User "system:serviceaccount:default:csi-nodeplugin" cannot create resource "csidrivers" in API group "csi.storage.k8s.io" at the cluster scope
E1004 20:44:29.154980       1 k8s_register.go:118] Failed to create CSIDriver object: csidrivers.csi.storage.k8s.io is forbidden: User "system:serviceaccount:default:csi-nodeplugin" cannot create resource "csidrivers" in API group "csi.storage.k8s.io" at the cluster scope
E1004 20:46:29.160309       1 k8s_register.go:118] Failed to create CSIDriver object: csidrivers.csi.storage.k8s.io is forbidden: User "system:serviceaccount:default:csi-nodeplugin" cannot create resource "csidrivers" in API group "csi.storage.k8s.io" at the cluster scope
E1004 20:48:29.166816       1 k8s_register.go:118] Failed to create CSIDriver object: csidrivers.csi.storage.k8s.io is forbidden: User "system:serviceaccount:default:csi-nodeplugin" cannot create resource "csidrivers" in API group "csi.storage.k8s.io" at the cluster scope

What I expected is the container should fail when it is unable to create CRD type.

[vladimirvivien]

/kind bug

[lpabon]

🛂 ⛔️
Hi, this repo has been split up into two repos:

• cluster-driver-registrar: Registers the driver with Kubernetes by setting up a CRD
• node-driver-registrar: Registers the driver with the kubelet on the node.

This repo has been closed, and no new changes will be accepted. Please move your content to one of these repos.

Thank you,