Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SourceVolumeMode type to v1.PersistentVolumeMode #683

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Change SourceVolumeMode type to v1.PersistentVolumeMode #683

merged 1 commit into from
Apr 5, 2022

Conversation

RaunakShah
Copy link
Contributor

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR updates the type of SourceVolumeMode from string to v1.PersistentVolumeMode. Also update the generated code and vendored dependancies.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Change SourceVolumeMode type to v1.PersistentVolumeMode

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2022
@RaunakShah RaunakShah mentioned this pull request Apr 5, 2022
Merged
@xing-yang
Copy link
Collaborator

Does this affect the manifest?

@RaunakShah
Copy link
Contributor Author

Does this affect the manifest?

I reran the update scripts with no change

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaunakShah, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022
@xing-yang
Copy link
Collaborator

@RaunakShah Can you backport this to release-6.0?

@k8s-ci-robot k8s-ci-robot merged commit 67501cd into kubernetes-csi:master Apr 5, 2022
@RaunakShah RaunakShah mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humblec humblec Awaiting requested review from humblec

@pohly pohly Awaiting requested review from pohly

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RaunakShah @xing-yang @k8s-ci-robot