Add support for configmap in checkpointer #320
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
|
ok to test |
|
Can someone publish details of the failed build (bootkube-etcd-dev) and let me know how i can fix it? |
|
@dhawal55 the PR tests are a bit in a state of flux - and there are some flakes we're still working through (and not currently able to expose the logs publicly - but it's on roadmap). Sorry for the delay on this (and thank you for the contribution!). I'll try and take a look at this/test early next week. |
aaronlevy
added
kind/feature
cmd/checkpoint/main.go
Outdated
| cp, err = checkpointConfigMapVolumes(client, cp) | ||
| if err != nil { | ||
| //TODO(aaron): This can end up spamming logs at times when api-server is unavailable. To reduce spam | ||
| // we could only log error if api-server can't be contacted and existing secret doesn't exist. |
There was a problem hiding this comment.
s/existing secret/existing configmap/
There was a problem hiding this comment.
ah, good catch, it's a copy paste mistake. I will correct it
|
Overall this looks good, thank you for contributing this! I'll run some tests against it, but assuming those pass - we should be able to get this merged soon. |
|
Can one of the admins verify this patch? |
|
rktbot run tests |
|
The PR tests might actually be down right now (due to S3 outages). |
|
rktbot run tests |
|
@dhawal55 would you also mind squashing your commits? |
|
@dhawal55 also looks like there are some conflicts that need to be resolved |
|
rktbot run checkpointer tests |
dhawal55
force-pushed
the
configmap_support
branch
from
62dd4e6
to
b82b9c2
Compare
|
Squashed the commits and fixed merge issues |
|
rktbot run checkpointer tests |
|
I manually tested this and it worked. The checkpointer-dev test I believe has an unrelated issue. @pbx0 when you get a chance can you look into the failed test. It looks like re-running the etcd-scale test the second time failed. |
Fixes #124