-
Notifications
You must be signed in to change notification settings - Fork 224
Replace deprecated env vars passed to the kubelet-wrapper #351
Replace deprecated env vars passed to the kubelet-wrapper #351
Conversation
The following environment variables used by kubelet-wrapper have been deprecated: * KUBELET_VERSION has been replaced with KUBELET_IMAGE_TAG * KUBELET_ACI has replaced with KUBELET_IMAGE_URL * RKT_OPTS has been replaces with RKT_RUN_ARGS https://github.com/coreos/coreos-overlay/blob/build-1220/app-admin/kubelet-wrapper/files/kubelet-wrapper#L29-L39
Can one of the admins verify this patch? |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ok to test |
I signed it! |
@pbx0 CLA is signed and this is ready for review. Thanks! |
@carolynvs thank you for fixing this! Would it work for you to hold off on getting this merged until closer to the k8s v1.6.0 release (end of March-ish)? The reason I ask is that I know there are some installations that base decisions off these values - and changing it mid-minor-release might cause some headaches. I was hoping to get changes like this, and #246, wrapped into the bootkube release containting v1.6.0, as that provides a pretty clear upgrade line for existing users. |
@carolynvs actually, ignore my previous comment - for some reason I was thinking we were generating the kubelet service file, but this is just updating the hack/documentation examples - which shouldn't affect existing users. Let me run a quick test on this and see if we can get it merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the fix!
This fixes #207.
The following environment variables used by kubelet-wrapper have been
deprecated:
KUBELET_VERSION
has been replaced withKUBELET_IMAGE_TAG
KUBELET_ACI
has replaced withKUBELET_IMAGE_URL
RKT_OPTS
has been replaces withRKT_RUN_ARGS
See https://github.com/coreos/coreos-overlay/blob/build-1220/app-admin/kubelet-wrapper/files/kubelet-wrapper#L29-L39.