Makefile: Use 'command -v selinuxenabled' instead of hard-coded path #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hard-coded path landed in 488216f (Make sure selinuxenabled exists before executing it, 2016-10-17, cri-o#154), but there's no need to require that path. Using 'command -v' (in POSIX [1]) supports anyone who has selinuxenabled in their PATH. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/command.html Signed-off-by: W. Trevor King <wking@tremily.us>
k8s-ci-robot
added
cncf-cla: yes
size/XS
|
Hi @wking. Thanks for your PR. I'm waiting for a openshift or kubernetes-incubator member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
|
I think this can be merged without running E2E test. |
runcom
added a commit
to runcom/ocid-1
that referenced
this pull request
Feb 23, 2018
This patch fixes selinuxopt generation as found in: ``` install /usr/sbin/selinuxenabled -D -m 644 crio.conf /etc/crio/crio.conf ``` The above is clearly wrong when installing the configuration because `commmand -v` outputs the path of selinuxenabled as well, resulting in /usr/bin/selinuxenabled -Z This patch fixes that by just echoing the -Z as needed. Issue introduced in cri-o#1363 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
Nack, this has broken docker hub CD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hard-coded path landed in 488216f (#154), but there's no need to require that path. Using
command -v(in POSIX) supports anyone who hasselinuxenabledin theirPATH.