container_exec: Fix terminal setting for exec #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly inheriting tty true from main container. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
k8s-ci-robot
added
size/XS
runcom
reviewed
Mar 9, 2018
| @@ -766,6 +766,9 @@ func PrepareProcessExec(c *Container, cmd []string, tty bool) (*os.File, error) | |||
|
|
|||
| pspec := c.Spec().Process | |||
| pspec.Args = cmd | |||
| // We need to default this to false else it will inherit terminal as true | |||
| // from the container. | |||
| pspec.Terminal = false | |||
There was a problem hiding this comment.
mmm that's why we changed it in the first place to inherit, do we always want this to be false?
There was a problem hiding this comment.
We can let the caller decide if they want to inherit and pass it down explicity as true.
|
LGTM, just a question |
|
LGTM |
|
/test all |
|
/test e2e_fedora |
2 similar comments
|
/test e2e_fedora |
|
/test e2e_fedora |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly inheriting tty true from main container.
@runcom @rhatdan PTAL
Closes #1433
Signed-off-by: Mrunal Patel mrunalp@gmail.com