Fix handling of /dev/shm mounting inside of containers #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
size/L
|
@mrunalp @umohnani8 PTAL, I think if this test passes, it proves that we are sharing /dev/shm between containers. For some reason tests are not currently running locally on my host. |
k8s-ci-robot
added
size/M
rhatdan
force-pushed
the
shm
branch
2 times, most recently
from
0a9ad8d
to
f83d074
Compare
k8s-ci-robot
added
size/L
rhatdan
changed the title
k8s-ci-robot
added
size/M
umohnani8
reviewed
May 3, 2018
test/shm.bats
Outdated
| echo "$output" | ||
| [ "$status" -eq 0 ] | ||
| pod_id="$output" | ||
| run crictl create "$pod_id" "$TESTDIR"/container_sleep.json "$TESTDATA"/sandbox_config.json |
There was a problem hiding this comment.
Should be $TESTDATA/container_sleep.json
There was a problem hiding this comment.
Thanks for hitting me with a clue bat.
umohnani8
reviewed
May 3, 2018
test/shm.bats
Outdated
| echo "$output" | ||
| [ "$status" -eq 0 ] | ||
|
|
||
| run crictl create "$pod_id" "$TESTDIR"/container_redis.json "$TESTDATA"/sandbox_config.json |
There was a problem hiding this comment.
Should be $TESTDATA/container_redis.json
|
Tests are blowing up because it is looking in the wrong place for the json files. |
umohnani8
reviewed
May 3, 2018
test/testdata/container_sleep.json
Outdated
| { | ||
| "key": "PATH", | ||
| "value": "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" | ||
| }, |
There was a problem hiding this comment.
@rhatdan the comma is causing the tests to blow up
Add test to make sure /dev/shm is shared between containers in CRI-O Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
/test all |
|
@mrunalp @umohnani8 @wking @runcom PTAL |
|
LGTM |
|
/test kata-containers |
|
All Green Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com
- What I did
- How I did it
- How to verify it
- Description for the changelog