OpenShift tests for docker compose v3 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
LGTM. Unfortunately because of my distro I can't test this. Could someone else do a quick test? |
|
I found following results: |
|
@surajnarwade Buildconfig tests are failing due to #521 changes; the tests added here are working. |
|
@ashetty1 what changes? I don't believe we've updated anything related to buildconfig since then. @surajnarwade can you try again? |
|
@cdrage the change in examples/buildconfig/docker-compose.yml |
|
@cdrage okay |
ashetty1
force-pushed
the
v3_tests
branch
2 times, most recently
from
c16e968
to
606d29d
Compare
|
@cdrage Could you take a look at this too. It is WIP because I am planning to add more tests as new features come in. But if you think it could be merged, I am cool with that too. |
|
@ashetty1 , I just tried this PR, I think |
|
@surajnarwade weird. Works for me. Can you just try: ./script/test_in_openshift/run.sh script/test_in_openshift/tests/v3-redis.sh |
|
change route to |
|
What's the status of this @ashetty1 ? Perhaps you can rebase against master? 👍 |
|
@cdrage Apologies. Give me a day. Will follow up on this. |
ashetty1
changed the title
|
@cdrage @surajnarwade kindly give it a spin. Have rebased and squashed the commits. |
|
Works with the exception of Docker Compose v3 environment variables test not coming up: Running tests for environment variable for docker compose v3
Running kompose up ...
INFO We are going to create OpenShift DeploymentConfigs, Services for your Dockerized application.
If you need different kind of resources, use the 'kompose convert' and 'oc create -f' commands instead.
INFO Deploying application in "myproject" namespace
INFO Successfully created Service: redis
INFO Successfully created Service: web
INFO Successfully created DeploymentConfig: redis
INFO Successfully created ImageStream: redis
INFO Successfully created DeploymentConfig: web
INFO Successfully created ImageStream: web
Your application has been deployed to OpenShift. You can run 'oc get dc,svc,is' for details.
No resources found.
Waiting for the pods to come up ...
No resources found.
No resources found.
No resources found.
No resources found.
No resources found.
No resources found.
No resources found.
No resources found.
No resources found.
No resources found.
No resources found. |
|
@cdrage can you try once more and push this? |
|
@ashetty1 works now! Mergin' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding OpenShift tests for docker compose v3 support on Kompose
Ref: #600