Disable dab

[cdrage]

See issue: #390

Remove DAB as it is hard to maintain / not much usage / DAB is still
experimental in Docker and there hasn't been much movement:
moby/moby#26876

MarkDeprecated does not work at the moment due to issue:
#652

However, that is not a blocker as we fatalF within ValidateFlags

[cdrage]

ping @sebgoa @kadel

[sebgoa]

so +1 , except that as you mention MarkDeprecated does not work.

[cdrage]

@sebgoa Yes, an issue with Cobra, which already has a fix, see: spf13/cobra#466 will just have to wait until it's merged upstream. But since we error out anyways if --bundle is passed, this will still work. We'll just have to update vendoring once spf13/cobra#466 is merged 👍

[cdrage]

I've also updated the commit title / information.

We're disabling DAB not removing it, as the code for conversion is still there for future use!

[cdrage]

Okay. Tests pass now. @kadel @surajssd want to do a quick review?

[surajnarwade]

works for me :)

[procrypt]

@cdrage LGTM and +1 for disabling DAB 💃

[procrypt]

@cdrage Do we need to write the functional tests for dab in golang since we are disabling it.

[pradeepto]

@cdrage Do we need to write the functional tests for dab in golang since we are disabling it.

No, we definitely shouldn't but I will let @cdrage and others take the final call.

[cdrage]

@procrypt @surajnarwade Remeber to go through the review process and hit "approve" 👍 But since I got two confirmations, let's go ahead and merge this!