Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Migrate kube-aws to node.kubernetes.io/role: control-plane taint #1876

Closed
mumoshu opened this issue Jun 30, 2020 · 2 comments
Closed

Migrate kube-aws to node.kubernetes.io/role: control-plane taint #1876

mumoshu opened this issue Jun 30, 2020 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mumoshu
Copy link
Contributor

mumoshu commented Jun 30, 2020

See https://groups.google.com/forum/#!topic/kubernetes-sig-cluster-lifecycle/6HSVqGlyCrI

We currently use the old taint in the number of places:

@dominicgunn
Copy link
Contributor

This could be a breaking change for users who might have sets that depend on being able to query by role=master. We should plan carefully around implementation here to avoid potential disruption to end-users.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants