This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Ask for confirmation in destroy command #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Tests missing |
Codecov Report
@@ Coverage Diff @@
## master #1178 +/- ##
=======================================
Coverage 36.07% 36.07%
=======================================
Files 63 63
Lines 3803 3803
=======================================
Hits 1372 1372
Misses 2217 2217
Partials 214 214Continue to review full report at Codecov.
|
|
Related: #249 |
|
@jorge07 Thanks again for your contribution! I don't mind adding tests in this case, but would you verify this by some manual test? |
|
I already did some manual tests for the use cases. |
|
Added release note in the PR description. |
|
@jorge07 LGTM. Thank you very much for your contribution 😄 |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1165
Release note:
kube-aws destroyrequires confirmation before proceeding. Add the force flag likekube-aws destroy --forceto skip confirming for CI/CD or scripting purpose.