Migrate Kubernetes v1.9.1 cluster/addons/registry to Kubespray #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hswong3i
changed the title
hswong3i
changed the title
ant31
approved these changes
Feb 6, 2018
woopstar
added a commit
to woopstar/kubespray
that referenced
this pull request
Feb 6, 2018
In PR kubernetes-sigs#2244 the `registry_enabled` is missing in defaults, causing a deployment to fail, if it is not set in k8s-cluster.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch migrate the original Kubernets addon "registry" into Kubespray as Ansible role.
Due to recent Kubernetes changes (kubernetes/kubernetes#58564 and kubernetes/kubernetes#49213), kube-registry-proxy is being removed from v1.9.2. BTW, a private repository is usually useful for custom deployment, e.g. if we need to build some custom image only exists in our own kubernetes deployment, but not push to any elsewhere.
This simple implementation doesn't handle PV and PVC but just use
emptyDir: {}For testing, change
registry_enabledastrueunderinventory/group_vars/k8s-cluster.ymland deploy with--tags registry.