Registry Addon Fixup

[hswong3i]

Integrate both changes from:

• Add PVC support for Registry addon
• Add Optional Namespace supprot for Registry Addon
• Remove original .yaml which no longer useful for our implementation
• Some other else minor fixup

[ghost]

While we are here could you check network plugin and change hostPort to hostNetwork in case plugin is calico?

[ghost]

Is it okay to hard code .cluster.local in REGISTRY_HOST when cluster domain might be different?

[hswong3i]

I am using kubespray default calico for all of my development, so could confirm that hostport works as expected?

[ghost]

As far as I know calico doesn't support hostPort, to be sure I've tested this again and it didn't work.

Edit:
From https://kubernetes.io/docs/concepts/cluster-administration/network-plugins/

Limitation: Due to kubernetes/kubernetes#31307, HostPort won’t work with CNI networking plugin at the moment. That means all hostPort attribute in pod would be simply ignored.

[hswong3i]

That’s strange... I do that for Nginx Ingress (#2324) too with hostport but it works ?_?

[ghost]

With brief look through issues seems like this issue hasn't fixed yet or it has very recently

[hswong3i]

@k1-hedayati please check the following:

• https://github.com/projectcalico/cni-plugin/issues/323#issuecomment-314286830
• Move HostPort port-opening from kubenet to kubelet/cni kubernetes/kubernetes#31307 (comment)
• Update CNI plugin to newest version; support ConfigLists kubernetes/kubernetes#42202

AFAIK, hostPort + cni is now working with k8s 1.9.x + Calico 2.3.x + Calico cni-plugin 1.9.x ;-)

Also see:

• calico_version: "v2.6.2"
• calico_cni_version: "v1.11.0"

[ghost]

@hswong3i Great, that's good news, so there is no need for hostNetwork

[hswong3i]

ping @Atoms need you review it, thanks

[hswong3i]

@Atoms already running this patch in my production for almost 2 weeks and looks stable enough, may you give a hand for review?

[hswong3i]

may someone give a hand and so let it go?

[woopstar]

ci check this

[hswong3i]

ci not run...

[hswong3i]

@woopstar i had been using this patch for almost a month and all looks good enough for my production, would you mind to give a hand for review?

anyway, CI not running this...

[ghost]

Why nobody is paying any attention

[rsmitty]

ci check this

[rsmitty]

I kicked CI for this PR. Sorry for the delay on it. CI isn't actually going to test the deployment of the registry, but it'll at least make sure the clusters still deploy successfully given these changes to the code base. Pending that, I'll merge it in.

[hswong3i]

CI looks good now~

[hswong3i]

@rsmitty thank you very much~~~