Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative paths for data_files in setup.cfg #2812

Merged
merged 1 commit into from May 25, 2018
Merged

Use relative paths for data_files in setup.cfg #2812

merged 1 commit into from May 25, 2018

Conversation

bogdando
Copy link
Contributor

pip install doesn't work with absolute paths

Follows-up #2170

Signed-off-by: Bogdan Dobrelya bogdando@mail.ru

@bogdando
Use relative paths for data_files in setup.cfg
518d5fd 
pip install doesn't work with absolute paths

Signed-off-by: Bogdan Dobrelya <bogdando@mail.ru>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2018
@bogdando
Copy link
Contributor Author

ci test this

@bogdando
Copy link
Contributor Author

@mattymo @flaper87 PTAL

@bogdando
Copy link
Contributor Author

How to test

From a venv, the commands should properly install/generate a package containing right $VENV/{etc,usr/share}/ paths:

$ python setup.py bdist_rpm && rpm2cpio dist/kubespray-2.5.1.dev103-1.noarch.rpm | cpio -idmv
$ pip install git+https://github.com/kubernetes-incubator/kubespray

Atoms
Atoms approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@Atoms Atoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't use rpm, but it seems good if this is working then it should be merged.

@bogdando bogdando merged commit c4b1808 into kubernetes-sigs:master May 25, 2018
@bogdando bogdando deleted the pip_install branch May 25, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atoms Atoms Atoms approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bogdando @Atoms @k8s-ci-robot