KubeCPUOvercommit alert is broken

[qxrpub]

Hi,

Multicluster version of the alert KubeCPUOvercommit is broken.

kubernetes-mixin/alerts/resource_alerts.libsonnet

Lines 35 to 43 in 033a6fb

	if $._config.showMultiCluster then {
	expr: |||
	sum(namespace_cpu:kube_pod_container_resource_requests:sum{%(kubeStateMetricsSelector)s,%(ignoringOverprovisionedWorkloadSelector)s}) by (%(clusterLabel)s) - (sum(kube_node_status_allocatable{%(kubeStateMetricsSelector)s,resource="cpu"}) by (%(clusterLabel)s) - max(kube_node_status_allocatable{%(kubeStateMetricsSelector)s,resource="cpu"}) by (%(clusterLabel)s)) > 0
	and
	(sum(kube_node_status_allocatable{%(kubeStateMetricsSelector)s,resource="cpu"}) by (%(clusterLabel)s) - max(kube_node_status_allocatable{%(kubeStateMetricsSelector)s,resource="cpu"}) by (%(clusterLabel)s)) > 0
	||| % $._config,
	annotations+: {
	description: 'Cluster {{ $labels.%(clusterLabel)s }} has overcommitted CPU resource requests for Pods by {{ $value }} CPU shares and cannot tolerate node failure.' % $._config,
	},

The namespace_cpu:kube_pod_container_resource_requests:sum metric is missing the kubeStateMetricsSelector ( job="kube-state-metrics) label. It only has cluster and namespace labels.

kubernetes-mixin/rules/apps.libsonnet

Lines 118 to 131 in 033a6fb

	{
	record: 'namespace_cpu:kube_pod_container_resource_requests:sum',
	expr: |||
	sum by (namespace, %(clusterLabel)s) (
	sum by (namespace, pod, %(clusterLabel)s) (
	max by (namespace, pod, container, %(clusterLabel)s) (
	kube_pod_container_resource_requests{resource="cpu",%(kubeStateMetricsSelector)s}
	) * on(namespace, pod, %(clusterLabel)s) group_left() max by (namespace, pod, %(clusterLabel)s) (
	kube_pod_status_phase{phase=~"Pending|Running"} == 1
	)
	)
	)
	||| % $._config,
	},