Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

hack/git-version.sh doesn't check for staged/indexed files #132

Closed
aaronlevy opened this issue Sep 15, 2016 · 1 comment · Fixed by #951
Closed

hack/git-version.sh doesn't check for staged/indexed files #132

aaronlevy opened this issue Sep 15, 2016 · 1 comment · Fixed by #951
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/P3

Comments

@aaronlevy
Copy link
Contributor

aaronlevy commented Sep 15, 2016 •
edited

We currently only check if there are un-staged changes to mark the build version as "-dirty". We should probably also check for staged/uncommitted/untracked.
@aaronlevy aaronlevy added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/P2 labels Sep 15, 2016
@aaronlevy aaronlevy changed the title git-version doesn't check for staged/indexed files hack/git-version.sh doesn't check for staged/indexed files Sep 15, 2016
@wking wking mentioned this issue Mar 30, 2018
Merged
@wking
Copy link
Contributor

wking commented Mar 30, 2018

#951 fixes this by using git describe --dirty ..., and Git notices and flags staged files too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build/git-version: Only call 'git' once wking/bootkube
2 participants
@wking @aaronlevy