Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Use versioned config file in render/start as replacement of flags #565

Closed
aaronlevy opened this issue Jun 6, 2017 · 6 comments
Closed
Labels
area/render area/usability kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2

Comments

@aaronlevy
Copy link
Contributor

Before going 1.0 bootkube should have some compatibility enforcement. It's difficult to do this with flags, so we probably should move to something like a versioned config file that is consumed by both the render and start subcommands.

@colemickens
Copy link
Contributor

/area render

@colemickens
Copy link
Contributor

start currently only takes two flags: --asset-dir and --pod-manifest-path.

I would suggest that we treat --asset-dir as the pointer to the state+configuration for the cluster. Any configuration file would be implicitly part of the asset dir. In the asset dir, we could introduce a new configuration file bootkube.yaml or some such, with cluster-specific details, like the kubelet pod manifest path location.

We could continue to support the flags for some time, persisting them into the asset-dir as we render, and encourage users to move to a configuration file and then eventually drop the individual flags we support in render / start other than --asset-dir.

Alternatively, we might consider adopting either kubeadm's "MasterConfiguration" yaml config file and supporting a subset of fields, or probably better, support the new Cluster API which seems built for tools like bootkube.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 23, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/render area/usability kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2
Projects
None yet
Development

No branches or pull requests

4 participants